Rich Edit Box proposal patched
Moderator: Rathinagiri
- kcarmody
- Posts: 152
- Joined: Tue Oct 07, 2014 11:13 am
- Has thanked: 8 times
- Been thanked: 45 times
- Contact:
Rich Edit Box proposal patched
I reported a bug with Find/Replace in the current Rich Edit demo, which Claudio kindly fixed in January (http://hmgforum.com/viewtopic.php?f=20&t=4533). For some reason, I did not find out about Claudio's fix until today.
I have now merged this change into the RichEditBox proposal I made last October (http://hmgforum.com/viewtopic.php?f=43&t=4496). This proposal includes a much enhanced Rich Edit demo, and it now also includes Claudio's patch 3 for version 3.4.2.
My revised RichEditBox proposal is on my site at http://kevincarmody.com/hmg. At the same location, I have also posted a zip file that contains what I call patch 3a, which includes Claudio's patch 3 and the fix he made in January. The January fix is only one line in h_windows.prg.
Zip for patch 3a http://kevincarmody.com/hmg/hmg.3.4.2_patch_3a.zip
Zip for my revised proposal http://kevincarmody.com/hmg/HmgChangeProposal.zip
Compiled Rich Edit demo http://kevincarmody.com/hmg/SAMPLES/Con ... x/demo.exe
I have now merged this change into the RichEditBox proposal I made last October (http://hmgforum.com/viewtopic.php?f=43&t=4496). This proposal includes a much enhanced Rich Edit demo, and it now also includes Claudio's patch 3 for version 3.4.2.
My revised RichEditBox proposal is on my site at http://kevincarmody.com/hmg. At the same location, I have also posted a zip file that contains what I call patch 3a, which includes Claudio's patch 3 and the fix he made in January. The January fix is only one line in h_windows.prg.
Zip for patch 3a http://kevincarmody.com/hmg/hmg.3.4.2_patch_3a.zip
Zip for my revised proposal http://kevincarmody.com/hmg/HmgChangeProposal.zip
Compiled Rich Edit demo http://kevincarmody.com/hmg/SAMPLES/Con ... x/demo.exe
- serge_girard
- Posts: 2656
- Joined: Sun Nov 25, 2012 2:44 pm
- DBs Used: 1 MySQL - MariaDB
2 DBF - Location: Belgium
- Has thanked: 936 times
- Been thanked: 173 times
- Contact:
- Rathinagiri
- Posts: 5351
- Joined: Tue Jul 29, 2008 6:30 pm
- DBs Used: MariaDB, SQLite, SQLCipher and MySQL
- Location: Sivakasi, India
- Has thanked: 212 times
- Been thanked: 232 times
- Contact:
Thank you. I am sure Claudio would visit and consider.
East or West HMG is the Best.
South or North HMG is worth.
...the possibilities are endless.
South or North HMG is worth.
...the possibilities are endless.
- srvet_claudio
- Posts: 2124
- Joined: Thu Feb 25, 2010 8:43 pm
- Location: Uruguay
- Has thanked: 55 times
- Been thanked: 247 times
- Contact:
Thanks, I will check
- srvet_claudio
- Posts: 2124
- Joined: Thu Feb 25, 2010 8:43 pm
- Location: Uruguay
- Has thanked: 55 times
- Been thanked: 247 times
- Contact:
Wow!!!! Kevin your demo is very nice,kcarmody wrote:I reported a bug with Find/Replace in the current Rich Edit demo, which Claudio kindly fixed in January (http://hmgforum.com/viewtopic.php?f=20&t=4533). For some reason, I did not find out about Claudio's fix until today.
I have now merged this change into the RichEditBox proposal I made last October (http://hmgforum.com/viewtopic.php?f=43&t=4496). This proposal includes a much enhanced Rich Edit demo, and it now also includes Claudio's patch 3 for version 3.4.2.
My revised RichEditBox proposal is on my site at http://kevincarmody.com/hmg. At the same location, I have also posted a zip file that contains what I call patch 3a, which includes Claudio's patch 3 and the fix he made in January. The January fix is only one line in h_windows.prg.
Zip for patch 3a http://kevincarmody.com/hmg/hmg.3.4.2_patch_3a.zip
Zip for my revised proposal http://kevincarmody.com/hmg/HmgChangeProposal.zip
Compiled Rich Edit demo http://kevincarmody.com/hmg/SAMPLES/Con ... x/demo.exe
but some changes that you propose are not entirely appropriate to incorporate in HMG, because they deviate from the standard behavior of Windows, for example changes made in RichEditBox_StreamIn() and RichEditBox_StreamOut() functions. And the changes made in HMG_IsUTF8 change the normal behavior of Harbour, the idea of this function is not to detect the true UTF-8 character set, the idea is to determine if it is due to use Unicode functions or not in the process a string.
I do not like OS-based controls that do not work in standard form, because they are often difficult to maintain as it evolves OS.
I think the changes you propose are very good for developing a word processor but not to the general operation of the RichEditBox control, my suggestion is to implement these changes in the demo, but not in the HMG library.
I repeat your demo is very good.
- serge_girard
- Posts: 2656
- Joined: Sun Nov 25, 2012 2:44 pm
- DBs Used: 1 MySQL - MariaDB
2 DBF - Location: Belgium
- Has thanked: 936 times
- Been thanked: 173 times
- Contact:
- srvet_claudio
- Posts: 2124
- Joined: Thu Feb 25, 2010 8:43 pm
- Location: Uruguay
- Has thanked: 55 times
- Been thanked: 247 times
- Contact:
Yes, is very easy include as external function in an app.serge_girard wrote:Claudio,
No other way to keep Kevin's changes so how?
Serge
- srvet_claudio
- Posts: 2124
- Joined: Thu Feb 25, 2010 8:43 pm
- Location: Uruguay
- Has thanked: 55 times
- Been thanked: 247 times
- Contact:
I will prepare a demo.srvet_claudio wrote:Yes, is very easy include as external function in an app.serge_girard wrote:Claudio,
No other way to keep Kevin's changes so how?
Serge
- serge_girard
- Posts: 2656
- Joined: Sun Nov 25, 2012 2:44 pm
- DBs Used: 1 MySQL - MariaDB
2 DBF - Location: Belgium
- Has thanked: 936 times
- Been thanked: 173 times
- Contact: