Page 1 of 2

Rich Edit Box proposal patched

Posted: Mon Apr 04, 2016 1:38 pm
by kcarmody
I reported a bug with Find/Replace in the current Rich Edit demo, which Claudio kindly fixed in January (http://hmgforum.com/viewtopic.php?f=20&t=4533). For some reason, I did not find out about Claudio's fix until today.

I have now merged this change into the RichEditBox proposal I made last October (http://hmgforum.com/viewtopic.php?f=43&t=4496). This proposal includes a much enhanced Rich Edit demo, and it now also includes Claudio's patch 3 for version 3.4.2.

My revised RichEditBox proposal is on my site at http://kevincarmody.com/hmg. At the same location, I have also posted a zip file that contains what I call patch 3a, which includes Claudio's patch 3 and the fix he made in January. The January fix is only one line in h_windows.prg.

Zip for patch 3a http://kevincarmody.com/hmg/hmg.3.4.2_patch_3a.zip
Zip for my revised proposal http://kevincarmody.com/hmg/HmgChangeProposal.zip
Compiled Rich Edit demo http://kevincarmody.com/hmg/SAMPLES/Con ... x/demo.exe

Re: Rich Edit Box proposal patched

Posted: Mon Apr 04, 2016 1:46 pm
by serge_girard
Thanks Kevin !

Serge

Re: Rich Edit Box proposal patched

Posted: Mon Apr 04, 2016 2:19 pm
by Rathinagiri
Thank you. I am sure Claudio would visit and consider.

Re: Rich Edit Box proposal patched

Posted: Mon Apr 04, 2016 4:13 pm
by srvet_claudio
Thanks, I will check

Re: Rich Edit Box proposal patched

Posted: Mon Apr 04, 2016 5:08 pm
by kcarmody
srvet_claudio wrote:Thanks, I will check
Thank you, Claudio, and thanks for the patch you made in January.

Re: Rich Edit Box proposal patched

Posted: Mon Apr 04, 2016 8:08 pm
by srvet_claudio
kcarmody wrote:I reported a bug with Find/Replace in the current Rich Edit demo, which Claudio kindly fixed in January (http://hmgforum.com/viewtopic.php?f=20&t=4533). For some reason, I did not find out about Claudio's fix until today.

I have now merged this change into the RichEditBox proposal I made last October (http://hmgforum.com/viewtopic.php?f=43&t=4496). This proposal includes a much enhanced Rich Edit demo, and it now also includes Claudio's patch 3 for version 3.4.2.

My revised RichEditBox proposal is on my site at http://kevincarmody.com/hmg. At the same location, I have also posted a zip file that contains what I call patch 3a, which includes Claudio's patch 3 and the fix he made in January. The January fix is only one line in h_windows.prg.

Zip for patch 3a http://kevincarmody.com/hmg/hmg.3.4.2_patch_3a.zip
Zip for my revised proposal http://kevincarmody.com/hmg/HmgChangeProposal.zip
Compiled Rich Edit demo http://kevincarmody.com/hmg/SAMPLES/Con ... x/demo.exe
Wow!!!! Kevin your demo is very nice,
but some changes that you propose are not entirely appropriate to incorporate in HMG, because they deviate from the standard behavior of Windows, for example changes made in RichEditBox_StreamIn() and RichEditBox_StreamOut() functions. And the changes made in HMG_IsUTF8 change the normal behavior of Harbour, the idea of this function is not to detect the true UTF-8 character set, the idea is to determine if it is due to use Unicode functions or not in the process a string.

I do not like OS-based controls that do not work in standard form, because they are often difficult to maintain as it evolves OS.

I think the changes you propose are very good for developing a word processor but not to the general operation of the RichEditBox control, my suggestion is to implement these changes in the demo, but not in the HMG library.

I repeat your demo is very good.

Re: Rich Edit Box proposal patched

Posted: Tue Apr 05, 2016 2:40 pm
by serge_girard
Claudio,

No other way to keep Kevin's changes so how?

Serge

Re: Rich Edit Box proposal patched

Posted: Tue Apr 05, 2016 2:59 pm
by srvet_claudio
serge_girard wrote:Claudio,

No other way to keep Kevin's changes so how?

Serge
Yes, is very easy include as external function in an app.

Re: Rich Edit Box proposal patched

Posted: Tue Apr 05, 2016 3:04 pm
by srvet_claudio
srvet_claudio wrote:
serge_girard wrote:Claudio,

No other way to keep Kevin's changes so how?

Serge
Yes, is very easy include as external function in an app.
I will prepare a demo.

Re: Rich Edit Box proposal patched

Posted: Tue Apr 05, 2016 3:09 pm
by serge_girard
Thank you VERY much !

Serge