HMG 2.9.0 (Forum test)
Moderator: Rathinagiri
- Roberto Lopez
- HMG Founder
- Posts: 4004
- Joined: Wed Jul 30, 2008 6:43 pm
HMG 2.9.0 (Forum test)
Harbour MiniGUI 2.9.0 Changelog:
English:
- Fixed: Grid (CellNavigation). OnChange event not fired when selection is automatically changed after accepting cell edit with [Enter].
Regards,
Roberto.
English:
- Fixed: Grid (CellNavigation). OnChange event not fired when selection is automatically changed after accepting cell edit with [Enter].
Regards,
Roberto.
- Attachments
-
- hmg290.rar
- (367.24 KiB) Downloaded 372 times
Regards/Saludos,
Roberto
(Veritas Filia Temporis)
Roberto
(Veritas Filia Temporis)
- Rathinagiri
- Posts: 5471
- Joined: Tue Jul 29, 2008 6:30 pm
- DBs Used: MariaDB, SQLite, SQLCipher and MySQL
- Location: Sivakasi, India
- Contact:
Re: HMG 2.9.0 (Forum test)
Thanks a lot Roberto.
East or West HMG is the Best.
South or North HMG is worth.
...the possibilities are endless.
South or North HMG is worth.
...the possibilities are endless.
Re: HMG 2.9.0 (Forum test)
Thank´s Master Roberto,
for this nice and great work.
Regards,
for this nice and great work.
Regards,
Re: HMG 2.9.0 (Forum test)
Hi Roberto,Roberto Lopez wrote:Harbour MiniGUI 2.9.0 Changelog:
There is a double checking for CellNavigation flag in the h_windows.prg.
Please take a look for the following code:
Code: Select all
* Grid Processing .....................................
if (_HMG_SYSDATA [1] [i] = "GRID") .Or. (_HMG_SYSDATA [1] [i] = "MULTIGRID")
IF _HMG_SYSDATA [32] [i] == .T. // first checking for CellNavigation flag
* Grid Key Handling .........................
If GetNotifyCode ( lParam ) = LVN_KEYDOWN
IF _HMG_SYSDATA [32] [i] == .T. // check again??
Do Case
...
Kind Regards,
Grigory Filatov
"Everything should be made as simple as possible, but no simpler." Albert Einstein
Grigory Filatov
"Everything should be made as simple as possible, but no simpler." Albert Einstein
- Roberto Lopez
- HMG Founder
- Posts: 4004
- Joined: Wed Jul 30, 2008 6:43 pm
Re: HMG 2.9.0 (Forum test)
CellNavigation has been a very complicated and difficult to debug feature.gfilatov wrote:Hi Roberto,Roberto Lopez wrote:Harbour MiniGUI 2.9.0 Changelog:
There is a double checking for CellNavigation flag in the h_windows.prg.
Please take a look for the following code:May be to fix an aboved issue in this buildCode: Select all
* Grid Processing ..................................... if (_HMG_SYSDATA [1] [i] = "GRID") .Or. (_HMG_SYSDATA [1] [i] = "MULTIGRID") IF _HMG_SYSDATA [32] [i] == .T. // first checking for CellNavigation flag * Grid Key Handling ......................... If GetNotifyCode ( lParam ) = LVN_KEYDOWN IF _HMG_SYSDATA [32] [i] == .T. // check again?? Do Case ...
It is possible that the code could be optimized, but until now, I've focused on bugs.
I'll take a look at it ASAP.
Thanks for reporting.
Regards,
Roberto.
Regards/Saludos,
Roberto
(Veritas Filia Temporis)
Roberto
(Veritas Filia Temporis)
Re: HMG 2.9.0 (Forum test)
Roberto,Roberto Lopez wrote:CellNavigation has been a very complicated and difficult to debug feature.
It is possible that the code could be optimized, but until now, I've focused on bugs.
I'll take a look at it ASAP.
Thanks for reporting.
Thanks for your attention, maestro
I'm glad to help for code's optimization.
Kind Regards,
Grigory Filatov
"Everything should be made as simple as possible, but no simpler." Albert Einstein
Grigory Filatov
"Everything should be made as simple as possible, but no simpler." Albert Einstein
- Roberto Lopez
- HMG Founder
- Posts: 4004
- Joined: Wed Jul 30, 2008 6:43 pm
Re: HMG 2.9.0 (Forum test)
You are right. It was a completely nonsense double checkgfilatov wrote: There is a double checking for CellNavigation flag in the h_windows.prg.
Please take a look for the following code:
I've removed the extra 'if'.
Thanks for reporting.
Regards,
Roberto.
Regards/Saludos,
Roberto
(Veritas Filia Temporis)
Roberto
(Veritas Filia Temporis)
Re: HMG 2.9.0 (Forum test)
Talking about code optimization, the lines:
could be rewritten:
According to a quick test that i have done, the second "optimized" version is more than twice faster compared to the first.
P.S. Of course the above "optimization" it is proposed just for "educational / academical" reasons and in no way should be taken as correction, because we all know that the "real life coding" has its own rules, priorities and necessities..
regards,
---
Pete
Code: Select all
if (_HMG_SYSDATA [1] [i] = "GRID") .Or. (_HMG_SYSDATA [1] [i] = "MULTIGRID")
IF _HMG_SYSDATA [32] [i] == .T.
Code: Select all
if (_HMG_SYSDATA [1] [i] $ "MULTIGRID")
IF (_HMG_SYSDATA [32] [i])
P.S. Of course the above "optimization" it is proposed just for "educational / academical" reasons and in no way should be taken as correction, because we all know that the "real life coding" has its own rules, priorities and necessities..
regards,
---
Pete