HMG 2.9.0 (Forum test)

HMG announcements; Latest HMG-related news, releases, fixes and updates.

Moderator: Rathinagiri

Post Reply
User avatar
Roberto Lopez
HMG Founder
Posts: 4004
Joined: Wed Jul 30, 2008 6:43 pm

HMG 2.9.0 (Forum test)

Post by Roberto Lopez »

Harbour MiniGUI 2.9.0 Changelog:

English:

- Fixed: Grid (CellNavigation). OnChange event not fired when selection is automatically changed after accepting cell edit with [Enter].


Regards,

Roberto.
Attachments
hmg290.rar
(367.24 KiB) Downloaded 372 times
Regards/Saludos,

Roberto


(Veritas Filia Temporis)
User avatar
Rathinagiri
Posts: 5471
Joined: Tue Jul 29, 2008 6:30 pm
DBs Used: MariaDB, SQLite, SQLCipher and MySQL
Location: Sivakasi, India
Contact:

Re: HMG 2.9.0 (Forum test)

Post by Rathinagiri »

Thanks a lot Roberto.
East or West HMG is the Best.
South or North HMG is worth.
...the possibilities are endless.
User avatar
esgici
Posts: 4543
Joined: Wed Jul 30, 2008 9:17 pm
DBs Used: DBF
Location: iskenderun / Turkiye
Contact:

Re: HMG 2.9.0 (Forum test)

Post by esgici »

Thanks a lot Le Roy :)

Best Regards

--

Esgici
Viva INTERNATIONAL HMG :D
User avatar
Vanguarda
Posts: 543
Joined: Wed Feb 11, 2009 10:56 am
Location: Americana - SP
Contact:

Re: HMG 2.9.0 (Forum test)

Post by Vanguarda »

Thank´s Master Roberto,
for this nice and great work.


Regards,
--
Paulo Sérgio Durço (Vanguarda)


http://hmglights.wordpress.com/
User avatar
gfilatov
Posts: 1060
Joined: Fri Aug 01, 2008 5:42 am
Location: Ukraine
Contact:

Re: HMG 2.9.0 (Forum test)

Post by gfilatov »

Roberto Lopez wrote:Harbour MiniGUI 2.9.0 Changelog:
Hi Roberto,

There is a double checking for CellNavigation flag in the h_windows.prg.
Please take a look for the following code:

Code: Select all

			* Grid Processing .....................................

			if (_HMG_SYSDATA [1] [i] = "GRID") .Or. (_HMG_SYSDATA [1] [i] = "MULTIGRID") 

				IF _HMG_SYSDATA [32] [i] == .T.                // first checking for CellNavigation flag
	
       					* Grid Key Handling .........................

					If GetNotifyCode ( lParam ) = LVN_KEYDOWN

						IF _HMG_SYSDATA [32] [i] == .T.          // check again??

							Do Case
...
May be to fix an aboved issue in this build :?:
Kind Regards,
Grigory Filatov

"Everything should be made as simple as possible, but no simpler." Albert Einstein
User avatar
Roberto Lopez
HMG Founder
Posts: 4004
Joined: Wed Jul 30, 2008 6:43 pm

Re: HMG 2.9.0 (Forum test)

Post by Roberto Lopez »

gfilatov wrote:
Roberto Lopez wrote:Harbour MiniGUI 2.9.0 Changelog:
Hi Roberto,

There is a double checking for CellNavigation flag in the h_windows.prg.
Please take a look for the following code:

Code: Select all

			* Grid Processing .....................................

			if (_HMG_SYSDATA [1] [i] = "GRID") .Or. (_HMG_SYSDATA [1] [i] = "MULTIGRID") 

				IF _HMG_SYSDATA [32] [i] == .T.                // first checking for CellNavigation flag
	
       					* Grid Key Handling .........................

					If GetNotifyCode ( lParam ) = LVN_KEYDOWN

						IF _HMG_SYSDATA [32] [i] == .T.          // check again??

							Do Case
...
May be to fix an aboved issue in this build :?:
CellNavigation has been a very complicated and difficult to debug feature.

It is possible that the code could be optimized, but until now, I've focused on bugs.

I'll take a look at it ASAP.

Thanks for reporting.

Regards,

Roberto.
Regards/Saludos,

Roberto


(Veritas Filia Temporis)
User avatar
gfilatov
Posts: 1060
Joined: Fri Aug 01, 2008 5:42 am
Location: Ukraine
Contact:

Re: HMG 2.9.0 (Forum test)

Post by gfilatov »

Roberto Lopez wrote:CellNavigation has been a very complicated and difficult to debug feature.

It is possible that the code could be optimized, but until now, I've focused on bugs.

I'll take a look at it ASAP.

Thanks for reporting.
Roberto,

Thanks for your attention, maestro :!:

I'm glad to help for code's optimization. :idea:
Kind Regards,
Grigory Filatov

"Everything should be made as simple as possible, but no simpler." Albert Einstein
User avatar
Roberto Lopez
HMG Founder
Posts: 4004
Joined: Wed Jul 30, 2008 6:43 pm

Re: HMG 2.9.0 (Forum test)

Post by Roberto Lopez »

gfilatov wrote: There is a double checking for CellNavigation flag in the h_windows.prg.
Please take a look for the following code:
You are right. It was a completely nonsense double check :)

I've removed the extra 'if'.

Thanks for reporting.

Regards,

Roberto.
Regards/Saludos,

Roberto


(Veritas Filia Temporis)
User avatar
Pete-WG
Posts: 14
Joined: Sat Aug 02, 2008 6:28 am

Re: HMG 2.9.0 (Forum test)

Post by Pete-WG »

Talking about code optimization, the lines:

Code: Select all

if (_HMG_SYSDATA [1] [i] = "GRID") .Or. (_HMG_SYSDATA [1] [i] = "MULTIGRID")

            IF _HMG_SYSDATA [32] [i] == .T.
could be rewritten:

Code: Select all

if (_HMG_SYSDATA [1] [i] $ "MULTIGRID")

            IF (_HMG_SYSDATA [32] [i])
According to a quick test that i have done, the second "optimized" version is more than twice faster compared to the first.

P.S. Of course the above "optimization" it is proposed just for "educational / academical" reasons and in no way should be taken as correction, because we all know that the "real life coding" has its own rules, priorities and necessities..


regards,

---
Pete
Post Reply